diff options
author | Andreas Schneider <asn@cryptomilk.org> | 2018-09-26 13:04:05 +0200 |
---|---|---|
committer | Andreas Schneider <asn@cryptomilk.org> | 2018-09-26 13:05:34 +0200 |
commit | 47bb1dac985910d206868c89f9cc15e3e368ccdb (patch) | |
tree | ee1eabf030b390b658a90f7d584e0c1143429e5b /src/cmocka.c | |
parent | 8006c18a48eb968976e58f90e39ca4bbeca1038d (diff) | |
download | cmocka-47bb1dac985910d206868c89f9cc15e3e368ccdb.tar.gz cmocka-47bb1dac985910d206868c89f9cc15e3e368ccdb.tar.xz cmocka-47bb1dac985910d206868c89f9cc15e3e368ccdb.zip |
cmocka: Silence clang analyzer warning
It has no way to mark things as false postivies or teach it that things
abort.
Signed-off-by: Andreas Schneider <asn@cryptomilk.org>
Diffstat (limited to 'src/cmocka.c')
-rw-r--r-- | src/cmocka.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/src/cmocka.c b/src/cmocka.c index 7b02b32..b21fe15 100644 --- a/src/cmocka.c +++ b/src/cmocka.c @@ -802,6 +802,10 @@ static int get_symbol_value( ListNode *value_node = NULL; return_value = list_first(child_list, &value_node); assert_true(return_value); + /* Add a check to silence clang analyzer */ + if (return_value == 0) { + goto out; + } *output = (void*) value_node->value; return_value = value_node->refcount; if (value_node->refcount - 1 == 0) { @@ -818,9 +822,9 @@ static int get_symbol_value( list_remove_free(target_node, free_symbol_map_value, (void*)0); } return return_value; - } else { - cm_print_error("No entries for symbol %s.\n", symbol_name); } +out: + cm_print_error("No entries for symbol %s.\n", symbol_name); return 0; } |