diff options
author | Andreas Schneider <asn@samba.org> | 2020-02-17 11:56:38 +0100 |
---|---|---|
committer | Andreas Schneider <asn@samba.org> | 2020-02-17 11:56:38 +0100 |
commit | 589f8aacf11fbf1615da8d87200afb95ebb03802 (patch) | |
tree | f596164b528739ee9e49a83c2432fd292f72c122 | |
parent | e2d59b13cbaf6d22dba15ecd9844ff79f2b2f74d (diff) | |
download | nss_wrapper-589f8aacf11fbf1615da8d87200afb95ebb03802.tar.gz nss_wrapper-589f8aacf11fbf1615da8d87200afb95ebb03802.tar.xz nss_wrapper-589f8aacf11fbf1615da8d87200afb95ebb03802.zip |
nwrap: Some code cleanup for nwrap_load_module_fn()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
-rw-r--r-- | src/nss_wrapper.c | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/src/nss_wrapper.c b/src/nss_wrapper.c index 5c4c972..3d9c3dc 100644 --- a/src/nss_wrapper.c +++ b/src/nss_wrapper.c @@ -1471,21 +1471,23 @@ static int libc_getnameinfo(const struct sockaddr *sa, static void *nwrap_load_module_fn(struct nwrap_backend *b, const char *fn_name) { - void *res; - char *s; + void *res = NULL; + char *s = NULL; + int rc; - if (!b->so_handle) { + if (b->so_handle == NULL) { NWRAP_LOG(NWRAP_LOG_ERROR, "No handle"); return NULL; } - if (asprintf(&s, "_nss_%s_%s", b->name, fn_name) == -1) { + rc = asprintf(&s, "_nss_%s_%s", b->name, fn_name); + if (rc == -1) { NWRAP_LOG(NWRAP_LOG_ERROR, "Out of memory"); return NULL; } res = dlsym(b->so_handle, s); - if (!res) { + if (res == NULL) { NWRAP_LOG(NWRAP_LOG_ERROR, "Cannot find function %s in %s", s, b->so_path); |